Restore task item selection highlight for Cmd+A#4798
Merged
ComputelessComputer merged 1 commit intomainfrom Mar 28, 2026
Merged
Restore task item selection highlight for Cmd+A#4798ComputelessComputer merged 1 commit intomainfrom
ComputelessComputer merged 1 commit intomainfrom
Conversation
Collaborator
ComputelessComputer
commented
Mar 28, 2026
ComputelessComputer
commented
- add a custom TipTap task item node view that preserves text selection across checkbox rows
- wire the shared extensions export to the new task item implementation
- add a regression test for the task item node view DOM
- override the TipTap task item node view to avoid contenteditable=false on the checkbox wrapper - keep checkbox toggling and attribute syncing behavior unchanged - add a regression test for the task item node view DOM
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for char-cli-web canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.